WebGPURenderer: Fix V8 deoptimizations. #32405
Open
+34
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Contributor
|
@mrdoob its super nice! Im curious how you are testing all these recent improvements? |
Owner
Author
In different ways. Which ones are you curious about? |
Contributor
|
@mrdoob I saw for the visual one its very straightforward image comparaison + reference blender/khronos , but for this one and the one about really small performance gain i cant even notice on my devices usually, so curious if its directly from profiler or other tooling ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several V8 deoptimization patterns in the WebGPU renderer to improve performance and stability.
RenderObject.js: OptimizedgetKeysby caching prototype keys in a WeakMap, significantly reducing reflection overhead.Renderer.js,Nodes.js,NodeBuilder.js,UniformNode.js: Replaceddeletekeyword usage withundefinedassignment to prevent hidden class transitions and keep object shapes stable.These changes ensure more stable hidden classes and reduce garbage collection overhead associated with dictionary mode objects.