This repository was archived by the owner on Sep 14, 2023. It is now read-only.
Open
Conversation
Author
|
@mre Haha, you mentioned this PR today, but it never got merged :) |
Owner
|
Oh yeah. I think the reason is that I never got around to benchmarking the change myself. If there is no noticeable perf-improvement I'd opt for keeping the BTreeMap impl as it's part of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I just watched your talk and you mentioned there, that you use
BTreeMapand I thought I can try to contribute to make it a little bit faster.This PR replaces
BTreeMapwithHashMapwith fnv hasher. As far as I know it's probably the fastest available HashMap option in Rust world. Once I improved speed of whatlang by ~30% just replacing standard (default) HashMap hasher withfnv.Regarding benchmarks: it looks like most of them got better, but some got worse. Please double check yourself if the change really makes sense.
Also if you have particular reasons to prefer
BTreeMapinstead ofHashMap(e.g. you care about order), please feel free to reject this PR. But if so you have to reflect this fact in your tests, because they're still green ;)