Skip to content

Conversation

@jbampton
Copy link
Contributor

Move rubocop config to the linters directory

https://docs.rubocop.org/rubocop/integration_with_other_tools.html#git-pre-commit-hook-integration-with-pre-commit

We removed jumanjihouse rubocop in #450

@jbampton jbampton requested a review from matz as a code owner June 25, 2025 04:41
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing code quality and consistency by integrating the official Rubocop linter into the pre-commit hook system. This change streamlines the enforcement of Ruby coding standards and replaces a previously removed Rubocop setup, ensuring continuous code style adherence.

Highlights

  • Pre-commit Hook Integration: I've integrated the official Rubocop linter (v1.77.0) into the project's .pre-commit-config.yaml. This ensures that Ruby code style checks are automatically performed before commits, standardizing code quality.
  • Rubocop Configuration: The newly added Rubocop pre-commit hook is configured to use a specific configuration file located at .github/linters/.rubocop.yml, allowing for centralized and version-controlled style guidelines.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the official RuboCop pre-commit hook, replacing a previously used one. The change is straightforward, but I've identified a critical issue with an invalid Git revision for the hook that would prevent it from working. I've also suggested improvements for efficiency by limiting the hook to Ruby files and for conciseness by removing optional fields. A code suggestion is provided to address all these points.

@jbampton jbampton force-pushed the pre-commit-add-official-rubocop branch from a811caf to cc50528 Compare June 25, 2025 04:49
@bovi bovi merged commit 2128ced into mruby:master Jun 25, 2025
3 checks passed
@jbampton jbampton deleted the pre-commit-add-official-rubocop branch June 25, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants