Skip to content

Conversation

@gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Nov 9, 2025

Hello,

This pull request introduces mruby-uriparser, a URI parsing library for mruby that wraps the uriparser C library. It provides an alternative to existing URI libraries with a focus on standards compliance and robust parsing.

Thank you!

@gemmaro gemmaro requested a review from matz as a code owner November 9, 2025 11:38
@gemini-code-assist
Copy link

Summary of Changes

Hello @gemmaro, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates a new URI parsing library, mruby-uriparser, into the mruby ecosystem. By wrapping the uriparser C library, it aims to provide a highly standards-compliant and robust solution for handling URIs, thereby offering a valuable alternative to existing mruby URI parsing options.

Highlights

  • New Library Introduction: This pull request introduces mruby-uriparser, a new URI parsing library for mruby.
  • C Library Wrapper: The mruby-uriparser library acts as a wrapper around the uriparser C library, leveraging its robust parsing capabilities.
  • Standards Compliance: The new library emphasizes standards compliance and robust parsing, offering an alternative to existing mruby URI solutions.
  • Gem Definition: A new file, mruby-uriparser.gem, has been added to define the metadata for the new gem, including its name, description, author, repository, and license.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gem definition for mruby-uriparser. The provided metadata is a good start, but it's missing the gem's dependencies. I've found in the gem's mrbgem.rake file that it depends on mruby-string-ext and mruby-error. I've added a review comment suggesting to add these to the gem file to ensure correct dependency resolution during builds.

@bovi bovi merged commit 88cbc0d into mruby:master Nov 9, 2025
3 checks passed
@gemmaro gemmaro deleted the add/mruby-uriparser branch November 29, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants