Skip to content

Conversation

@jbampton
Copy link
Contributor

Add pre-commit hook check-illegal-windows-names

@jbampton jbampton requested a review from matz as a code owner November 27, 2025 19:39
@gemini-code-assist
Copy link

Summary of Changes

Hello @jbampton, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on maintaining and improving the project's code quality and consistency by updating the pre-commit configuration. It brings several existing pre-commit hooks to their latest versions and introduces a new check to prevent issues with Windows-incompatible filenames, ensuring a more robust and compatible codebase.

Highlights

  • Pre-commit Hook Updates: Several pre-commit hooks, including gitleaks, pre-commit-hooks, actionlint, markdown-link-check, markdownlint-cli, and rubocop, have been updated to their latest versions to ensure the use of the most recent checks and features.
  • New Pre-commit Hook Added: A new pre-commit hook, check-illegal-windows-names, has been introduced to prevent the use of filenames that are invalid on Windows operating systems, enhancing cross-platform compatibility.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates several pre-commit hooks to their latest versions and introduces the check-illegal-windows-names hook. Keeping dependencies updated is great practice, and the new hook will improve cross-platform compatibility by preventing filenames that are invalid on Windows.

I've noted one major version upgrade for pre-commit-hooks from v5 to v6. I've left a specific comment regarding this with some details on potential breaking changes you should be aware of.

description: detect hardcoded secrets with gitleaks
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v5.0.0
rev: v6.0.0

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This updates pre-commit-hooks from v5.0.0 to v6.0.0, which is a major version update. It's worth being aware of the breaking changes introduced in v6.0.0, as they could impact your development workflow.

Some notable changes include:

  • Several hooks used in this configuration (check-case-conflict, check-executables-have-shebangs, check-shebang-scripts-are-executable) now require Python 3.8 or newer to run.
  • The autopep8-wrapper hook has been removed (it was not used in this project).
  • The underlying tools for check-json, check-toml, and check-yaml have been changed, which might lead to different behavior.

While pre-commit manages its own environments, it's good to be aware of these changes to prevent unexpected issues.

@matz matz merged commit c5edac2 into mruby:master Nov 28, 2025
3 checks passed
@jbampton jbampton deleted the update-pre-commit branch November 28, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants