Add support for env variables with SFTP client.

[di-ov]

This relates to and closes this issue: #1433

I basically saw how this was implemented in the exec() method in client.js and did a similar implementation.

I seems that it might be better to add an additional parameter to the sftp() method, i.e. in client.js it would appear as sftp(env, cb), I wasn't entirely sure, what do you think? Thanks!

[angelparaskov]

@mscdex we also would like to have such a solution.
May we expedite this one please?
Thanks

[mscdex]

I seems that it might be better to add an additional parameter to the sftp() method, i.e. in client.js it would appear as sftp(env, cb)

That would be the preferred approach.

[di-ov]

@mscdex thanks for the help, I did the changes. If it looks okay, I'll have a look at updating the docs.

[mscdex]

All that's needed now is a unit test. You'll probably have to use one similar to the last one in the SFTP test script to verify the environment is being sent properly before starting the subsystem.

[di-ov]

@mscdex so this look okay right? Would you be able to include it in the next release?

[unbekanntes-pferd]

@mscdex I'd also be interested in this solution. Anything that can be done to support this / move this forward?

[angelparaskov]

Is there anything we could do, to speed this up?

[vmiroslav]

Yea, I really need this ASAP , so if we can help you somehow to speed the process let us know

[di-ov]

@mscdex it's been quite a while since this is open, would you able to at least give some pointers on when you plan to work this project? thanks!

[angelparaskov]

Is this repo still alive @mscdex ?
Is there someone else that could approve merge requests?

[mscdex]

Landed in c19a821.