Skip to content

Resolve the "INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getOAuthIdentifier() never returns string so it can be removed from the return type" error detected by PHPStan #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
msyk merged 1 commit into from
Jan 31, 2026
Merged

Resolve the "INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getOAuthIdentifier() never returns string so it can be removed from the return type" error detected by PHPStan #144

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Supporting/CommunicationProvider.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@
* @return array|null
* @ignore
*/
private function getSupportingProviders(): null|array

Check failure on line 536 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Method INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getSupportingProviders() is unused.
{
try {
$this->callRestAPI([], true, 'GET', [], [],
Expand All @@ -550,10 +550,10 @@

/**
* @param $provider
* @return string|array|null
* @return array|null
* @ignore
*/
private function getOAuthIdentifier($provider): string|array|null
private function getOAuthIdentifier($provider): array|null

Check failure on line 556 in src/Supporting/CommunicationProvider.php

View workflow job for this annotation

GitHub Actions / Run PHPStan (4) 

Method INTERMediator\FileMakerServer\RESTAPI\Supporting\CommunicationProvider::getOAuthIdentifier() is unused.
{
try {
$this->callRestAPI(
Expand Down
Loading