-
Notifications
You must be signed in to change notification settings - Fork 1
feat: download vchord from github releases #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughSingle Dockerfile updated: base image changed to cloudnative-pg/postgresql:16.8-14; multi-stage binary copy removed; ARG-driven runtime download/install of VectorChord added; image label renamed to cloudnativepg-postgresql-vectorchord; CMD simplified to start PostgreSQL preloading vchord.so. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Build as Docker Build
participant Host as VectorChord Host
participant Image as Final Image
participant Container as Runtime Container
participant Postgres as PostgreSQL
participant Vchord as vchord.so
Note over Build,Image: Build-time (single-stage)
Build->>Image: FROM cloudnative-pg/postgresql:16.8-14\nARG VCHORD_VERSION
Build->>Image: apt-get install wget, ca-certificates
Build->>Host: GET VectorChord .deb (PG16, ${VCHORD_VERSION})
Host-->>Build: .deb package
Build->>Image: dpkg -i vectorchord .deb\nremove temp files\nset label & CMD
Note over Container,Postgres: Runtime
Container->>Postgres: start postgres (shared_preload_libraries=vchord.so)
Postgres->>Vchord: load vchord.so
Vchord-->>Postgres: extension initialized
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Pull requests from the repository owner are approved automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (2)
.github/workflows/release.ymlis excluded by!**/*.yml.github/workflows/verify.ymlis excluded by!**/*.yml
📒 Files selected for processing (1)
Dockerfile(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Verify
Dockerfile
[warning] 24-24: Hadolint DL3008: Pin versions in apt-get install. Instead of 'apt-get install ' use 'apt-get install ='.
🪛 GitHub Check: Lint Dockerfile
Dockerfile
[failure] 24-24:
DL3047 info: Avoid use of wget without progress bar. Use wget --progress=dot:giga <url>. Or consider using -q or -nv (shorthands for --quiet or --no-verbose).
[failure] 24-24:
SC2046 warning: Quote this to prevent word splitting.
[failure] 24-24:
DL3015 info: Avoid additional packages by specifying --no-install-recommends
[failure] 24-24:
DL3008 warning: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
BREAKING CHANGE: revert to postgres 16.8
BREAKING CHANGE: revert to postgres 16.8