Skip to content

Conversation

@muhlba91
Copy link
Owner

@muhlba91 muhlba91 commented Oct 3, 2025

BREAKING CHANGE: revert to postgres 16.8

@coderabbitai
Copy link

coderabbitai bot commented Oct 3, 2025

Walkthrough

Single Dockerfile updated: base image changed to cloudnative-pg/postgresql:16.8-14; multi-stage binary copy removed; ARG-driven runtime download/install of VectorChord added; image label renamed to cloudnativepg-postgresql-vectorchord; CMD simplified to start PostgreSQL preloading vchord.so.

Changes

Cohort / File(s) Summary of Changes
Docker image build and runtime adjustments
Dockerfile
- Base image set to cloudnative-pg/postgresql:16.8-14 (from 17.5-7)
- Removed vchord binary build stage and copy
- Added ARG VCHORD_VERSION with default value
- Install wget and ca-certificates; download VectorChord package for PG16 (${VCHORD_VERSION}); dpkg -i install; cleanup temporary files
- Updated image label to cloudnativepg-postgresql-vectorchord
- Simplified CMD to launch postgres with shared_preload_libraries=vchord.so (removed extra search_path/logging_collector flags)

Sequence Diagram(s)

sequenceDiagram
  autonumber
  participant Build as Docker Build
  participant Host as VectorChord Host
  participant Image as Final Image
  participant Container as Runtime Container
  participant Postgres as PostgreSQL
  participant Vchord as vchord.so

  Note over Build,Image: Build-time (single-stage)
  Build->>Image: FROM cloudnative-pg/postgresql:16.8-14\nARG VCHORD_VERSION
  Build->>Image: apt-get install wget, ca-certificates
  Build->>Host: GET VectorChord .deb (PG16, ${VCHORD_VERSION})
  Host-->>Build: .deb package
  Build->>Image: dpkg -i vectorchord .deb\nremove temp files\nset label & CMD

  Note over Container,Postgres: Runtime
  Container->>Postgres: start postgres (shared_preload_libraries=vchord.so)
  Postgres->>Vchord: load vchord.so
  Vchord-->>Postgres: extension initialized
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly summarizes the primary change by indicating that the Dockerfile will now download the Vchord binary from GitHub releases instead of embedding it via a build stage, making it concise, specific, and directly aligned with the main feature introduced in the pull request.
Description Check ✅ Passed The description highlights the significant breaking change of reverting to PostgreSQL 16.8, which directly corresponds to one of the key updates in the Dockerfile and is therefore relevant to the changeset.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/vchord

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8de3a73 and 4e8c83a.

⛔ Files ignored due to path filters (2)
  • .github/workflows/release.yml is excluded by !**/*.yml
  • .github/workflows/verify.yml is excluded by !**/*.yml
📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: gitStream.cm
  • GitHub Check: gitStream.cm
  • GitHub Check: Build Container Image

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

gitstream-cm[bot]
gitstream-cm bot previously approved these changes Oct 3, 2025
@gitstream-cm
Copy link

gitstream-cm bot commented Oct 3, 2025

Pull requests from the repository owner are approved automatically.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5b2670 and 8de3a73.

⛔ Files ignored due to path filters (2)
  • .github/workflows/release.yml is excluded by !**/*.yml
  • .github/workflows/verify.yml is excluded by !**/*.yml
📒 Files selected for processing (1)
  • Dockerfile (2 hunks)
🧰 Additional context used
🪛 GitHub Actions: Verify
Dockerfile

[warning] 24-24: Hadolint DL3008: Pin versions in apt-get install. Instead of 'apt-get install ' use 'apt-get install ='.

🪛 GitHub Check: Lint Dockerfile
Dockerfile

[failure] 24-24:
DL3047 info: Avoid use of wget without progress bar. Use wget --progress=dot:giga <url>. Or consider using -q or -nv (shorthands for --quiet or --no-verbose).


[failure] 24-24:
SC2046 warning: Quote this to prevent word splitting.


[failure] 24-24:
DL3015 info: Avoid additional packages by specifying --no-install-recommends


[failure] 24-24:
DL3008 warning: Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

BREAKING CHANGE: revert to postgres 16.8
@muhlba91 muhlba91 merged commit 1c6ef9f into main Oct 3, 2025
9 checks passed
@muhlba91 muhlba91 deleted the feat/vchord branch October 3, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants