Disable Nagle algorithm for reduced latency#9
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Rabbit client and TcpServer to disable Nagle's algorithm for lower latency on both sides of the benchmark, updates connection endpoints to use IPAddress.Loopback, and restructures the Rabbit constructor to properly initialize dependencies.
- Refactor
Rabbitconstructor, initialize fields, and setTcpClient.NoDelay - Change
ConnectAsyncto useIPAddress.Loopbackand add.ConfigureAwait(false) - Update
TcpServerlistener to useIPAddress.Loopbackand setNoDelayon accepted clients
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| SerializersBenchmark/Network/Rabbit.cs | Changed to a normal constructor, set NoDelay, refactored serializer usage, and switched to IPAddress.Loopback |
| SerializersBenchmark/Network/Abstractions/TcpServer.cs | Switched to IPAddress.Loopback and disable Nagle on each accepted client |
Comments suppressed due to low confidence (1)
SerializersBenchmark/Network/Rabbit.cs:41
- Consider adding
.ConfigureAwait(false)to theFlushAsynccall to avoid capturing the synchronization context and maintain consistency with other async calls.
await stream.FlushAsync().ConfigureAwait(false);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.