-
Notifications
You must be signed in to change notification settings - Fork 20
feat: base45 #116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: base45 #116
Conversation
vmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Long time no see @mriise! Thanks for the PR.
|
I first thought the |
|
It just needs to feature flag alloc. I was sort of hoping base45 wasn't on the case insensitive list, the crate assumes it to be uppercase (because that's what the rfc says). I'll just toUpper() before handing it over to the crate. (oh god the camel case has infected me) |
|
@vmx unless we have a user waiting on this, im ok with waiting a bit for no_std to be merged upstream before this gets merged. |
|
merged and updated :) |
vmx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
fixes #100