Radiogroup binding converts true/false values to actual booleans before updating the model#68
Open
thedersen wants to merge 1 commit intomxriverlynn:masterfrom
Open
Radiogroup binding converts true/false values to actual booleans before updating the model#68thedersen wants to merge 1 commit intomxriverlynn:masterfrom
thedersen wants to merge 1 commit intomxriverlynn:masterfrom
Conversation
…re updating the model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When having radio buttons with true/false values, the model is updated with a string. This is quite annoying, since there's really no way of knowing whether the attribute is a string or a boolean.
This pull fixes it by converting 'true' to true and 'false' to false before updating the mode.