-
Notifications
You must be signed in to change notification settings - Fork 18
feat: upgrade to Python 3.12 #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThis pull request consists of updates to several configuration and documentation files. A comment was added to Changes
Possibly related PRs
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 88.88% 88.88%
=======================================
Files 2 2
Lines 108 108
=======================================
Hits 96 96
Misses 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
.github/dependabot.yml (1)
10-19: Dependency Groups Modification: FastAPI, Flake8, and Pytest Updates
- The FastAPI group now uses the wildcard pattern
"fastapi*"to potentially cover more related packages.- New groups for
flake8(with pattern"flake8*") andpytest(with patterns"pytest*"and"gevent") have been introduced.- Also, note the removal of the
pydanticgroup as mentioned in the AI summary. Please double-check that this removal is intentional and that these grouping changes fully align with your dependency management strategy.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.codacy.yml(1 hunks).github/dependabot.yml(1 hunks).github/workflows/python-app.yml(1 hunks)README.md(1 hunks)codecov.yml(1 hunks)postman_collections/python-samples-fastapi-restful.postman_collection.json(1 hunks)runtime.txt(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
- GitHub Check: pixeebot[bot]
- GitHub Check: pixeebot[bot]
- GitHub Check: pixeebot[bot]
- GitHub Check: pixeebot[bot]
- GitHub Check: pixeebot[bot]
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (9)
.codacy.yml (1)
1-2: Useful Documentation Reference AddedThe addition of the URL comment at the top provides a quick reference to the Codacy documentation. This is helpful for developers unfamiliar with the configuration format and does not interfere with any functionality.
postman_collections/python-samples-fastapi-restful.postman_collection.json (2)
1-8: Refined Metadata in the Postman CollectionThe metadata block (lines 2–8) has been updated with reformatting improvements that enhance readability while preserving all essential information.
9-161: Clear and Consistent API Endpoint FormattingThe configuration of API endpoints is well-structured and consistent throughout the file. The changes appear to be purely formatting-related and do not affect endpoint functionality.
codecov.yml (1)
1-2: Streamlined Codecov YAML ConfigurationThe removal of extraneous comments and the retention of a single helpful documentation link improves clarity and maintainability of the configuration.
README.md (1)
6-10: Updated Project Quality BadgesThe status section now features the new "Quality Gate Status" badge in place of the old SonarCloud bugs badge, along with the addition of CodeFactor and codebeat badges. This update better reflects the project's current quality metrics. Ensure that the URLs and project identifiers remain accurate.
runtime.txt (1)
1-2: New Python Runtime SpecificationThe newly added
runtime.txtfile clearly specifiespython-3.12as the required Python version. This change aligns with the updates in your CI workflow and documentation, ensuring consistency across the project..github/workflows/python-app.yml (1)
12-13: Environment Variable Update: Python Version Changed to 3.12
ThePYTHON_VERSIONenvironment variable is updated to3.12, which aligns with the new runtime requirement and ensures consistency with the newruntime.txtfile. Please verify that all dependencies and tests support Python 3.12..github/dependabot.yml (2)
7-9: Update Schedule Frequency for Pip Ecosystem
The schedule interval for the "pip" package ecosystem has been updated to "daily." This increased frequency can help catch updates faster; however, please confirm that daily checks fit your project’s maintenance and review cadence.
22-24: Github-Actions Update: Daily Schedule Confirmed
The schedule interval for the "github-actions" package ecosystem is now set to "daily," which is consistent with the pip ecosystem update. No issues observed with this change.
|



This change is
Summary by CodeRabbit
New Features
Chores
Documentation