chore(ci): limit container job to master branch pushes #354
Conversation
WalkthroughThe GitHub Actions workflow for building and pushing Docker images was updated. The Changes
Sequence Diagram(s)sequenceDiagram
participant GitHub Actions
participant Docker Buildx
participant GitHub Container Registry
GitHub Actions->>Docker Buildx: Start build (linux/amd64, no provenance, with cache)
Docker Buildx-->>GitHub Actions: Use GitHub Actions cache for build layers
Docker Buildx->>GitHub Container Registry: Push built image (with updated tags)
GitHub Actions-->>GitHub Actions: Job runs only on push to master
Possibly related PRs
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 2 2
Lines 111 111
=======================================
Hits 99 99
Misses 12 12
🚀 New features to boost your workflow:
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
.github/workflows/python-app.yml (2)
132-132: Specify target build platform
Locking the build tolinux/amd64provides consistency, but if you need multi-architecture support (e.g., ARM), consider expandingplatformsto include those.
135-135: Configure cache destination
Storing output withcache-to: type=gha,mode=maxwill populate the cache for future runs. If your cache grows large, you may want to adjust retention or scope the cached layers.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
.github/workflows/python-app.yml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (3)
.github/workflows/python-app.yml (3)
107-107: Restrict container job to master branch pushes
Thisifcondition ensures thecontainerjob only runs on actual pushes to themasterbranch (not on PRs), perfectly aligning with the PR objective.
133-133: Disable provenance metadata
Turning off provenance (provenance: false) speeds up builds but omits build provenance and SBOM data. Verify that dropping this metadata aligns with your security and compliance requirements.
134-134: Enable build cache source
Usingcache-from: type=ghais a great way to leverage GitHub Actions cache for faster rebuilds. Ensure that cache hits are effective by reviewing your build logs.
This change is
Summary by CodeRabbit