Skip to content

Conversation

@QuanMPhm
Copy link
Contributor

While testing calculate_storage_gb_hours, I realized that the default start and end arguments were not timezone aware, but the django timestamps for event times are. I've added timezone awareness to default start and end date arguments.

Also fixed s3-bucket-name cli argument name.

This is blocking nerc-project/coldfront-nerc#135

Added timezone awareness to default start and end date arguments.
Fixed `s3-bucket-name` cli arguement name.
@naved001
Copy link
Contributor

I realized that the default start and end arguments were not timezone aware, but the django timestamps for event times are.

So what was the impact of this?

@QuanMPhm
Copy link
Contributor Author

@naved001 Running calculate_storage_gb_hours with all default arguments would error out, saying that it can't compare timezone aware and unaware timestamps. In effect, this bug should have had zero impact on all prior invoices, since the invoices won't be generated if this error was encountered

@QuanMPhm QuanMPhm merged commit 05c9e2b into nerc-project:main Aug 12, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants