Add attributes to tracking allocation usage #277
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuanMPhm
force-pushed
the
270/billing_attr
branch
from
440754c to
ec222a5
Compare
knikolla
requested changes
Dec 3, 2025
knikolla
requested changes
Dec 3, 2025
knikolla
requested changes
Dec 3, 2025
QuanMPhm
force-pushed
the
270/billing_attr
branch
2 times, most recently
from
a53c4a5 to
a59ac5b
Compare
knikolla
requested changes
Dec 3, 2025
QuanMPhm
force-pushed
the
270/billing_attr
branch
from
a59ac5b to
d679a83
Compare
knikolla
approved these changes
Dec 3, 2025
knikolla
reviewed
Dec 3, 2025
naved001
approved these changes
Dec 3, 2025
Contributor
naved001
left a comment
naved001
left a comment
There was a problem hiding this comment.
Seems fine, just one nit picky comment.
Three new attributes have been added to track daily charges, previous charges, and an alert threshold for allocations. These attributes will help in monitoring and managing billing for cloud resources. More details described in nerc-project#270
QuanMPhm
force-pushed
the
270/billing_attr
branch
from
d679a83 to
5bb6ffe
Compare
naved001
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #270. I've introduced some pydantic models to load and validate the usage dicts. These attributes are not yet used in any way in any part of the code.