-
Notifications
You must be signed in to change notification settings - Fork 16
info about new allocation attributes to track Current Usage Invoice? #295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
joachimweyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small suggestions, otherwise it looks good.
|
|
||
| ### Understanding the New Attribute Format | ||
|
|
||
| represents the cost accumulated as of the end of that day |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the first letter be capitalized?
| threshold value. When the **Cumulative Daily Charges for Month** *exceed this value*, | ||
| an **email notification** will be **sent** to the **PI and Project Manager(s)**. | ||
|
|
||
| Additionally, a new *Allocation Attribute* labeled `Previous Charges` will display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar to how the alert email has a header, this would be easier to see if it had a header.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off on mentioning Previous Charges for now as that hasn't been fully defined yet. So please remove this paragraph for now.
|
|
||
| - Communicate usage patterns and trends to your **team or project members**. | ||
|
|
||
| ## Coming Soon: Monthly Allocation Alert Emails |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wouldn't be coming soon, it will be part of the same cronjob that updates the daily cumulative charge. Also please hold off on merging this PR until we have rolled out the CronJob. Or otherwise merge both of these sections with coming soon.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knikolla: Is this attribute: Monthly Allocation Alert Emails going to be Yes/No type that can be configured by the PI or Manager(s) on their allocations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand your question.
The attribute is called Monthly Allocation Cost Alert and in the next paragraph you explain exactly how it works. It's a dollar value that when exceeded by Cumulative Daily Charges for Month sends an email to PI and managers.
The value is set like any other attribute, by submitting a Change Request that changes it from the default value of 0.
| A new automated alert feature is coming soon to help PIs and Project Manager(s) | ||
| stay informed about budget overruns. We will introduce a new *Allocation Attribute* | ||
| labeled `Monthly Allocation Cost Alert`, which allows PIs or Managers to set a | ||
| threshold value. When the **Cumulative Daily Charges for Month** *exceed this value*, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: exceeds
| threshold value. When the **Cumulative Daily Charges for Month** *exceed this value*, | ||
| an **email notification** will be **sent** to the **PI and Project Manager(s)**. | ||
|
|
||
| Additionally, a new *Allocation Attribute* labeled `Previous Charges` will display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's hold off on mentioning Previous Charges for now as that hasn't been fully defined yet. So please remove this paragraph for now.
| - Ensure PIs are aware of over-usage through systematic alerts, so they don't | ||
| need to wait until the end of the monthly billing cycle to see the charges. | ||
|
|
||
| Once this feature launches, users will only need to set the `Monthly Allocation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my note above about this being part of the same cronjob that updates the daily cumulative charge.
joachimweyl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change suggested.
| Manager(s)**. To activate the notifications, PIs or Project Manager(s) simply need | ||
| to set this attribute on their allocation. | ||
|
|
||
| The **`Cumulative Daily Charges for Month`** attribute allows PIs or Manager(s) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cumulative Daily Charges for Month is where you can see last nights value not where you set the alert value. @knikolla correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is correct. This section seems to be a duplicate of the above section, which is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed this duplicate content
| For detailed instructions about **NERC's ColdFront** and how to use it, refer | ||
| to [this guide](allocation/coldfront.md). | ||
|
|
||
| !!! danger "Very Important: Project Title Length Limitation" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@knikolla: Lately, PIs have been using longer project titles, which is causing issues when creating RHOAI Workbenches with custom long names. We need to update the ColdFront plugin to enforce a maximum length of 25 characters for ColdFront Project titles. This ensures that Workbench names and their associated CRDs can fit properly within the auto-generated user namespace based on the project title.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Milstein Is this related to this? nerc-project/coldfront-plugin-cloud#225
In that PR you proposed 50. Via that ColdFront already has the ability to crop project names if they are longer, just the length needs to be adjusted.
It would be much better if this can be fixed by merging that PR to an appropriate maximum length so that it shortens the project title to an appropriate length regardless of what PIs insert. PIs aren't going to read the documentation before requesting a project.
Sorry, wrong @ to Quan by mistake.
Closes nerc-project/operations#1355