Fix ansible-lint violations and modernize Netdata ansible quck-start playbook#105
Open
guiand888 wants to merge 7 commits intonetdata:mainfrom
Open
Fix ansible-lint violations and modernize Netdata ansible quck-start playbook#105guiand888 wants to merge 7 commits intonetdata:mainfrom
guiand888 wants to merge 7 commits intonetdata:mainfrom
Conversation
- Fixed 25 linting violations in ansible-quickstart - Added proper playbook.yml with FQCN modules - Converted task files to proper format - Added handlers and notify statements
…documentation - Redacted secrets from vars/main.yml (claim_token, claim_rooms) - Set reclaim back to false and dbengine_multihost_disk_space to 2048 - Added configurable installation options (netdata_channel, netdata_auto_updates) - Added PR_SUMMARY.md to .gitignore - Moved detailed ansible instructions to parent README with relative link - Updated PR summary with comprehensive change documentation
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Netdata Ansible quickstart playbook by fixing ansible-lint violations and replacing deprecated installation methods with the current kickstart script approach. The changes ensure compliance with Ansible best practices while maintaining backward compatibility.
Key Changes:
- Fixed 25+ ansible-lint violations using FQCN and proper YAML formatting
- Replaced deprecated
netdata-claim.shwith modernkickstart.shthat handles both installation and claiming - Added proper playbook structure separating playbook-level elements from task files
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vars/main.yml | Added new configuration options for installation channel and auto-updates |
| templates/netdata.conf.j2 | Fixed template variable handling with proper Jinja2 syntax |
| tasks/main.yml | Converted import_playbook to import_tasks with proper FQCN |
| tasks/install.yml | Complete rewrite using modern kickstart script with integrated claiming |
| tasks/configure.yml | Streamlined configuration task with proper FQCN and path handling |
| tasks/claim.yml | Simplified to service verification since claiming moved to install |
| playbook.yml | New main playbook file with proper structure and handlers |
| README.md | Updated documentation with comprehensive usage instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
configuration-management/ansible-quickstart/tasks/configure.yml
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There are several issues with the playbook at it is:
This PR fixes those issues.
Most importantly, it ensure the role remains functional as
my-netdata.io/kickstart.shis deprecated.Key Changes
Ansible-lint Compliance
ansible.builtin.*)Modern Installation Approach
netdata-claim.shscript with modernkickstart.shapproachAdditional Installation Options
netdata_channel: Choose 'stable' or 'nightly' installationnetdata_auto_updates: Control automatic updates (default: false for automation)Improved Structure
playbook.ymlwith playbook-level elementsUsage
Configuration Examples