Close issue #58: Document link_count feature implementation status #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses issue #58 by providing comprehensive documentation that the requested
link_countfeature is already fully implemented and working in the current codebase.Issue Analysis
Issue #58 requested the ability to use
link_countparameter to avoid repetitive adjacency definitions:Requested syntax:
Key Findings
✅ Feature Status: The
link_countfeature is fully implemented and functional✅ Exact Syntax: The requested YAML syntax works perfectly
✅ Implementation: Robust implementation in
ngraph/blueprints.py✅ Test Coverage: Comprehensive test suite covering all scenarios
✅ Documentation: Well-documented with working examples
Implementation Details
The feature is implemented in
ngraph/blueprints.pyvia:_expand_adjacency_pattern(): Handles adjacency pattern expansion withlink_countparameter_create_link(): Creates multiple parallel links whenlink_count > 1_expand_adjacency(): Supportslink_countin top-level network adjacency_expand_blueprint_adjacency(): Supportslink_countin blueprint adjacencyTest Coverage
Comprehensive tests in
tests/test_blueprints.py:test_create_link_multiple(): Tests multiple parallel link creationtest_expand_adjacency_pattern_mesh_link_count(): Tests mesh pattern with link_counttest_process_direct_links_link_count(): Tests direct link definitionsDocumentation & Examples
Working examples found in:
docs/examples/clos-fabric.md(line 78): Showslink_count: 4in productiondocs/getting-started/tutorial.md: Demonstrateslink_count: 2docs/reference/dsl.md: Official parameter documentationOutcome
No code changes were required as the feature is already fully functional. Issue #58 can be closed as COMPLETED with the understanding that the requested functionality has been available and working all along.
The comprehensive technical documentation prepared for the issue comment (4,700+ characters) provides complete implementation details, usage examples, test verification, and migration guidance for users.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.