Skip to content

Conversation

@networmix
Copy link
Owner

Closing #71

@networmix networmix self-assigned this Jun 8, 2025
Copilot AI review requested due to automatic review settings June 8, 2025 00:22
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances developer experience, updates dataclass usage, and refines DSL expansion logic.

  • Refactors @dataclass declarations (removes slots=True) and cleans up import ordering.
  • Adjusts DSL expansion functions: uses None default for inherited risk groups and employs zip(..., strict=False) for adjacency variables.
  • Adds/updates developer tooling: setup/check scripts, CLI for API docs, Makefile targets, and CI workflows.

Reviewed Changes

Copilot reviewed 96 out of 96 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
ngraph/components.py Removed slots=True, reordered imports, updated from_dict.
ngraph/blueprints.py Changed default arg to None, added strict=False to zip().
dev/generate_api_docs.py Introduced argparse, refined exception, added file output.
dev/setup-dev.sh & dev/run-checks.sh New scripts for env setup and QA checks.
Makefile & dev/dev.md New/updated dev commands and documentation.
.github/workflows/python-test.yml Expanded Python matrix, added lint and type-check steps.
Comments suppressed due to low confidence (4)

ngraph/blueprints.py:165

  • Add or update a test case for _expand_group when inherited_risk_groups is not provided to verify the new default behavior initializes an empty set.
inherited_risk_groups: Set[str] | None = None,

ngraph/components.py:10

  • [nitpick] Previously declared @dataclass(slots=True) to save memory and improve attribute access; if slotted instances are desired, consider re-adding slots=True.
@dataclass

ngraph/blueprints.py:421

  • The strict parameter for zip() requires Python 3.10+. Ensure your project’s minimum Python version supports this change or adjust accordingly.
combo_dict = dict(zip(var_names, combo_tuple, strict=False))

dev/generate_api_docs.py:245

  • The indentation of the diagnostic print statements after writing the file appears inconsistent. Ensure all print calls are correctly nested under if output_to_file: so that output_path is always defined when used.
if output_to_file:

@networmix networmix changed the title Dev Merging from Dev, closing #71 Jun 8, 2025
@networmix networmix changed the title Merging from Dev, closing #71 Merging from Dev Jun 8, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ BugBot reviewed your changes and found no bugs!


BugBot free trial expires on June 10, 2025
You have used $0.00 of your $50.00 spend limit so far. Manage your spend limit in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@networmix networmix merged commit 90f3781 into main Jun 8, 2025
6 checks passed
@networmix networmix deleted the dev branch June 8, 2025 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants