-
Notifications
You must be signed in to change notification settings - Fork 9
Update Threat Prevention .NET Dependencies KB: Relocate, update requirements link, replace Salesforce image, and enable 8.0 sidebar #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
- Moved KB from docs-staging/needs-relocation/ to configuration-and-administration/ - Updated requirements link to threatprevention/7_5/requirements/overview - Fixed cross-product KB links to point to correct product directories - Removed incorrect .md extensions from internal links
- Updated link text to 'Netwrix Threat Prevention Requirements' - Changed URL to point to requirements overview page - Simplified wording to match new docs site structure
… copy and fix alt text - Add local PowerShell example image to 0-images folder - Replace incorrect Salesforce image with PowerShell output image - Fix alt text from "Dialog box for selecting monitoring plan settings" to "PowerShell Example Output" - Remove cross-product KB links per Option B strategy
This comment was marked as resolved.
This comment was marked as resolved.
|
@netwrix/threatprevention-docs team - This PR needs your review/approval. It relocates an NTP KB to its folder. I also added KBs to the NTP 8.0 sidebar. |
Pull Request Review: Threat Prevention .NET Dependencies KBSummaryThis PR successfully relocates and updates the .NET Dependencies KB article for Threat Prevention. The changes are well-structured and align with the documentation site's architecture. Overall, this is a solid PR with good practices. ✅ Positive Aspects1. Excellent Organization & File Structure
2. Good Content Improvements
3. Smart Strategic Decision
4. Proper Sidebar Integration
📝 Minor Observations1. Missing Newline at End of FileThe markdown file is missing a trailing newline at the end: Recommendation: Add a newline after the last line. This is a common best practice in version control and prevents potential git warnings. 2. Hardcoded Version in LinkThe requirements link uses a hardcoded version https://docs.netwrix.com/docs/threatprevention/7_5/requirements/overviewQuestion: Should this link dynamically reflect the current version, or is 7.5 the canonical source for this information? If the KB is meant to be version-agnostic, consider whether this should point to the latest version or be documented as version-specific. 3. PowerShell Code BlockThe PowerShell command is well-formatted with proper syntax highlighting. Good use of code fencing. 🔍 Technical QualityCode Quality: ✅ Excellent
Best Practices: ✅ Followed
Security: ✅ No Concerns
Performance: ✅ Improved
Testing: ✅ Well DocumentedPR description includes comprehensive testing checklist covering:
🎯 RecommendationsPriority: Low
Documentation SuggestionConsider adding a comment in the Related Articles section noting that cross-product links will be restored in a future update, so future maintainers understand the intentional omission. 📊 Review Summary
🚀 ConclusionRecommendation: APPROVE with minor optional improvements. This PR demonstrates good understanding of the documentation architecture and makes meaningful improvements to the KB article. The strategic approach to cross-product links shows thoughtful planning. The changes are safe to merge as-is, with the trailing newline being the only suggestion worth considering (and even that is very minor). Great work! 🎉 |
Summary
Updates the .NET Dependencies KB for Netwrix Threat Prevention:
Changes
File Relocation
net_dependencies_for_netwrix_threat_prevention.mdfromdocs-staging/needs-relocation/todocs/kb/threatprevention/configuration-and-administration/Requirements Link
https://docs.netwrix.com/docs/threatprevention/7_5/requirements/overviewImage Replacement
docs/kb/threatprevention/0-images/ka0Qk000000DG8bIAG.png../0-images/ka0Qk000000DG8bIAG.pngCross-Product Links
Sidebar Fix
sidebars/threatprevention/8.0.jsTechnical Updates
Testing
/docs/kb/threatprevention/configuration-and-administration/net_dependencies_for_netwrix_threat_preventionRelated