Skip to content

fix: improve error message for invalid issuer URL in OAuth/OIDC flow … #13338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Eahtasham wants to merge 1 commit into
base: main
Choose a base branch
from
+17 −2
Open

fix: improve error message for invalid issuer URL in OAuth/OIDC flow … #13338

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions packages/core/src/lib/actions/signin/authorization-url.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,15 @@ export async function getAuthorizationUrl(
// If url is undefined, we assume that issuer is always defined
// We check this in assert.ts

const issuer = new URL(provider.issuer!)
// Better error handling here with URL which throws a TypeError if the URL is invalid
let issuer: URL
try {
issuer = new URL(provider.issuer!)
} catch (error) {
throw new TypeError(
`Invalid issuer URL: "${provider.issuer}". The issuer must be a valid URL. Error: ${error}`
)
}
const discoveryResponse = await o.discoveryRequest(issuer, {
[o.customFetch]: provider[customFetch],
// TODO: move away from allowing insecure HTTP requests
Expand All @@ -46,7 +54,14 @@ export async function getAuthorizationUrl(
)
}

url = new URL(as.authorization_endpoint)
// Add validation here too
try {
url = new URL(as.authorization_endpoint)
} catch (error) {
throw new TypeError(
`Invalid authorization endpoint URL: "${as.authorization_endpoint}" Error: ${error}`
)
}
}

const authParams = url.searchParams
Expand Down