fix: conditionally assign basePath in frameworks-sveltekit #13339
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
@Naptie is attempting to deploy a commit to the authjs Team on Vercel. A member of the Team first needs to authorize it. |
Broken Link Checker
1) /getting-started/migrate-to-better-auth
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
This PR fixes the incorrect assignment statement to the
basePathsetting in the frameworks-sveltekit package. It used to ignore the value set by the user and didn’t recognize the possible presence of theAUTH_URLenvironment variable, which, when set, caused the env-url-basepath-redundant warning to be spammed in the logs. In this PR, I moved the assignment statement into an if condition that checks if neither user-definedbasePathnor theAUTH_URLis present, which is supposed to be the only case wherebasePathshould be assigned a fallback value.Also, due to inappropriate implementation of the
coreSetEnvDefaultsfunction, it is unclear if it is supposed to be run once or multiple times - theenv-url-basepath-redundantwarning is logged each time it finds bothbasePathandAUTH_URLare present, but following this check in the function it immediately assignsbasePathto ensure it always has an value, causing all subsequent invocations of this function to annoyingly spam that warning in the console, as long asAUTH_URLis defined. Therefore,suppressBasePathWarningis now set to true when callingcoreSetEnvDefaultsto completely prevent that warning from being logged.🧢 Checklist
🎫 Affected issues
Fixes: #12795
📌 Resources