Respect avatar border for TextDrawable #16283
Open
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...since they can't resize automatically, so the border must be calculated into the radius Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
force-pushed
the
style/noid/textDrawableAvatarBorder
branch
from
8c544eb to
7c03008
Compare
Member
Author
|
Fixed the typo @alperozturk96 - thanks for the review 🙏 |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16283.apk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...since they can't resize automatically, so the border must be calculated into the radius.
Follow-up to #16227
🖼️ Screenshots
For testing have a file shared with you by a user that got deactivated, so you don't get an avatar from the server. The fallback is a TextDrawable but that doesn't resize, so in case of the avatar group the border needs to be calculated into the radius, else the avatar is (slightly) to big.