[main] Fix: Board cannot be undeleted #7505
Merged
+11
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theoholl
requested review from
elzody,
grnd-alt and
luka-nextcloud
as code owners
theoholl
changed the title
allowDeleted parameter through to BoardMapper::find() to find the relevant board.
grnd-alt
approved these changes
Jan 5, 2026
Member
|
thanks for your contribution, the code changes look fine, and work as expected 🔥 |
luka-nextcloud
approved these changes
Jan 7, 2026
… parameter through to BoardMapper::find() to find the relevant board. Signed-off-by: Theo <36564257+theoholl@users.noreply.github.com>
luka-nextcloud
force-pushed
the
fix-undelete-board
branch
from
f418d19 to
5dc5291
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #3534
Summary
On
main(and maybe other branches/versions), the undelete action is broken. The web endpoint returns a403 Permission deniederror.This is because the
PermissionService::getBoard()method is called without the allowDeleted parameter (it defaults to false), and, thus, throws aDoesNotExistExceptionerror. This error is then caught inPermissionService::getPermissions(), setting both$owner = falseand$acls = []. This results in all permissions being false.This pull request adds an optional
allowDeletedparameter to relevant functions.Screencast
Screencast.Fix.mp4