Keep the main codebase in container ephemeral storage#2504
Open
mcronce wants to merge 2 commits intonextcloud:masterfrom
Open
Keep the main codebase in container ephemeral storage#2504mcronce wants to merge 2 commits intonextcloud:masterfrom
mcronce wants to merge 2 commits intonextcloud:masterfrom
Conversation
… storage Signed-off-by: Mike Cronce <mike@quadra-tec.net>
Signed-off-by: Mike Cronce <mike@quadra-tec.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has several advantages
/var/www/htmlwas cephfs on 2x10Gb network and consumer-grade NVMe drives), updates between 29, 30, 31, and 32 went from ~135 minutes to ~5 minutes. The main culprits for the difference were thersyncstep and the code integrity check.It also may fix #2044; I don't want to speak for the person who originally filed it, but it sounded like they were asking for the same thing.
This is, obviously, a breaking change - anybody currently mounting in all of
/var/www/htmlneeds to now mount in several subdirectories instead. I'm not sure whether the breaking change is preferable over the maintenance burden of having a separate set of images; if a separate set of images is desired, I'll redo it that way. Notably, the helm chart already mounts them all in separately; the only change needed there is to no longer mount in/var/wwwand/var/www/html. I haven't looked for docker-compose files or anything like that.Other than that, I don't believe I broke anything. The example theme and any changed "built-in" config/custom apps will still be copied over when the version changes.