Skip to content

fix pendingIntent #2603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alperozturk96 merged 2 commits into from
Apr 2, 2025
Merged

fix pendingIntent #2603

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0c7da7
fix pendingIntent
tobiasKaminsky Mar 18, 2025
629c004
update doc
alperozturk96 Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 12 additions & 9 deletions app/src/main/java/it/niedermann/owncloud/notes/shared/util/WidgetUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,21 @@ private WidgetUtil() {
}

/**
* Android S requires either {@link PendingIntent#FLAG_MUTABLE} or
* {@link PendingIntent#FLAG_IMMUTABLE} to be set on a {@link PendingIntent}.
* This is enforced by Android and will lead to an app crash if neither of those flags is
* present.
* To keep the app working, this compatibility method can be used to add the
* {@link PendingIntent#FLAG_MUTABLE} flag on Android S and higher to restore the behavior of
* older SDK versions.
* Android 14 (API 34) and above require FLAG_IMMUTABLE
*
* @param flags wanted flags for {@link PendingIntent}
* @return {@param flags} | {@link PendingIntent#FLAG_MUTABLE}
* <p>
* Android 12 (API 31) and above allow FLAG_MUTABLE
*
* <p>
* Ensures compatibility with different Android API levels by setting appropriate flags for a PendingIntent.
*
* @param flags The original flags to be used for the PendingIntent.
* @return The modified flags with compatibility adjustments based on the Android API level.
*/
public static int pendingIntentFlagCompat(int flags) {
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
return flags | PendingIntent.FLAG_IMMUTABLE;
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.S) {
return flags | PendingIntent.FLAG_MUTABLE;
}
Expand Down
Loading