Skip to content

Conversation

@Kokika
Copy link
Contributor

@Kokika Kokika commented Apr 3, 2025

This PR addresses a bug in my initial descending lexicographical sorting implementation (#2487) where:

🐛 Bug:

Null pointer exception during category sort swich.

Incomplete sorting logic for lexicographical descending sort.

🔧 Fix:

Check for null ptr and initailize for 0.

Sorting applied for category filtering too.

Maintains backward compatibility

✅ Verification:

Validated on my phone with android studio

Confirmed no-breaking changes

Kokika added 3 commits April 4, 2025 09:51
Signed-off-by: Kornél Szekeres <szekereskornel@gmail.com>
Signed-off-by: Kornél Szekeres <szekereskornel@gmail.com>
Signed-off-by: Kornél Szekeres <szekereskornel@gmail.com>
@Kokika Kokika force-pushed the bugfix/sort-descending-lexicographical branch from 31b2496 to 03331be Compare April 4, 2025 08:05
@tobiasKaminsky tobiasKaminsky merged commit 7dac440 into nextcloud:main Apr 10, 2025
4 checks passed
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants