Skip to content

Conversation

@fm-sys
Copy link
Contributor

@fm-sys fm-sys commented Jun 17, 2025

The FAB was overlapping with the note preview, which was complained about in #2272 and many duplicate issues. This PR adds some padding to the end of the scroll view.

With this fix, the textview will still be displayed behind the fab, but it now will be possible to scroll the text further up thanks to a blank view component which gets added to the end if the scroll content.

THis will close #2272

PowerToys_Paste_20250617233248 PowerToys_Paste_20250617233312
Before: Important text may be hidden without posibility to see it Now: Text can be scrolled further up

@fm-sys fm-sys mentioned this pull request Jun 17, 2025
6 tasks
@fm-sys fm-sys force-pushed the padding-in-note-preview branch from 08249b1 to 3e9114c Compare June 17, 2025 22:05
@fm-sys
Copy link
Contributor Author

fm-sys commented Jun 20, 2025

The PR build is currently failing with

  - On artifact material-color-utilities-48ed8e86d9.module (com.github.nextcloud.android-common:material-color-utilities:48ed8e86d9) multiple problems reported:
      - in repository 'maven': artifact is not signed
      - in repository 'maven': expected a 'sha256' checksum of '66521c5651965b19eaab1fc24bbed9fc99c398437678e51a0a7b677f35037a0c' but was '6164d2c0add8d826d4310c92e17c8ba4deabfd81534206b75b2830a7dcf51e58'

This can indicate that a dependency has been compromised. Please carefully verify the checksums.

However that's a problem with the build pipeline independent of this PR, as build is failing for all other commits to this repository as well.

May to take a look? Thank you very much!

fm-sys and others added 2 commits June 22, 2025 17:11
Signed-off-by: fm-sys <64581222+fm-sys@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the padding-in-note-preview branch from 3e9114c to e5be621 Compare June 22, 2025 15:22
@AndyScherzinger AndyScherzinger added this to the 4.4.0 milestone Jun 22, 2025
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger
Copy link
Member

Tested successfully and added a slight simplification via 4a27f36 given that the extra space can now simply be added via the newly introduced parent element.

Thanks for this contribution / PR @fm-sys

I'll check with @tobiasKaminsky how quickly we an get this released 😃

@AndyScherzinger AndyScherzinger merged commit 4a2d744 into nextcloud:main Jun 22, 2025
22 of 23 checks passed
@fm-sys
Copy link
Contributor Author

fm-sys commented Jun 24, 2025

A new release would be great! In fact, it's almost a year since the last release and there are probably quite some other cool changes waiting to finally go live :)

@fm-sys fm-sys deleted the padding-in-note-preview branch June 24, 2025 21:25
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@Buntbart
Copy link

This padding fixed the problem with the overlapping edit button but apparently it adds a problem with the now overlapping keyboard when trying to actually edit the text...

@fm-sys
Copy link
Contributor Author

fm-sys commented Jul 25, 2025

It's not caused by this PR but a different change which seem to also be part of the new release. Should be relatively easy to fix though...

@AndyScherzinger
Copy link
Member

Looping in @alperozturk96 for the comments above since I am AFK

@fm-sys
Copy link
Contributor Author

fm-sys commented Jul 28, 2025

just ran a git bisect, commit caa792b seems to have caused the issues mentioned above as side effect...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit button overlaps content

3 participants