-
-
Notifications
You must be signed in to change notification settings - Fork 149
add bottom padding in note preview #2672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add bottom padding in note preview #2672
Conversation
08249b1 to
3e9114c
Compare
|
The PR build is currently failing with However that's a problem with the build pipeline independent of this PR, as build is failing for all other commits to this repository as well. May to take a look? Thank you very much! |
Signed-off-by: fm-sys <64581222+fm-sys@users.noreply.github.com>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
3e9114c to
e5be621
Compare
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
|
Tested successfully and added a slight simplification via 4a27f36 given that the extra space can now simply be added via the newly introduced parent element. Thanks for this contribution / PR @fm-sys I'll check with @tobiasKaminsky how quickly we an get this released 😃 |
|
A new release would be great! In fact, it's almost a year since the last release and there are probably quite some other cool changes waiting to finally go live :) |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
This padding fixed the problem with the overlapping edit button but apparently it adds a problem with the now overlapping keyboard when trying to actually edit the text... |
|
It's not caused by this PR but a different change which seem to also be part of the new release. Should be relatively easy to fix though... |
|
Looping in @alperozturk96 for the comments above since I am AFK |
|
just ran a |
The FAB was overlapping with the note preview, which was complained about in #2272 and many duplicate issues. This PR adds some padding to the end of the scroll view.
With this fix, the textview will still be displayed behind the fab, but it now will be possible to scroll the text further up thanks to a blank view component which gets added to the end if the scroll content.
THis will close #2272