Skip to content

General backend type safety improvements and php code modernization #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
binsky08 wants to merge 5 commits into
base: master
Choose a base branch
from
Open

General backend type safety improvements and php code modernization #846

binsky08 wants to merge 5 commits into from

Conversation

@binsky08
Copy link
Collaborator

@binsky08 binsky08 commented Sep 27, 2025

While trying to mitigate php8.4 deprecation warnings I ended in a comprehensive overhaul of our custom DB entity types and classes.
So we now have (almost everywhere) deterministic entity types from the controller to the entity class.

  1. I've added and applied a rector config for easier language migrations and php deprecation fixes
  2. Migrated implicit nullable parameters (deprecated since php8.4) to the explicit syntax introduced in php7.1; closes PHP 8.4 fix code #834
  3. Improved type safety in custom QBMapper classes and its callers by using a more strict entity typing
  4. Add .editorconfig to match Nextcloud's default file formatting when using an IDE like PhpStorm

@binsky08
improve in-code type usage and update php syntax to 8.1 using rector
be643a8 
Signed-off-by: binsky <timo@binsky.org>
@binsky08
improve type safety in custom QBMapper classes and its callers by usi…
864038b 
…ng a more strict entity typing

Signed-off-by: binsky <timo@binsky.org>
@binsky08
refine rector config to match php8.4 features but preserve compatibil…
1b30c74 
…ity to php8.1

fixes #834

Signed-off-by: binsky <timo@binsky.org>
@binsky08
add .editorconfig to match Nextcloud's default file formatting
0e5a9d2 
Signed-off-by: binsky <timo@binsky.org>
@binsky08 binsky08 added this to the 2.5.0 milestone Sep 27, 2025
@binsky08 binsky08 requested a review from animalillo September 27, 2025 22:05
@binsky08
fix calling decrypt in EncryptService with null parameter
ec7571a 
Signed-off-by: binsky <timo@binsky.org>
@binsky08 binsky08 mentioned this pull request Sep 28, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@animalillo animalillo Awaiting requested review from animalillo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.5.0

Development

Successfully merging this pull request may close these issues.

PHP 8.4 fix code

2 participants

@binsky08