Also show group display name when the group object is not loaded yet #56533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default only 25 group objects are loaded. If a user is assigend to a group, that isn't loaded yet, we only show the gid instead of the displayname. Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
kesselb
added
2. developing
Contributor
Author
|
cc @artonge @come-nc @susnux @benjaminfrueh for early feedback as you were involved in the other pr's. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is conflicting with 🙈
#55871
#56509
#56524
We are fetching the first 25 groups when opening the users list. If a user in that list has a group assigned that was not part of the first 25 groups, then we don't have the displayname.
Until:
As fetching the display names might be expensive, we should consider to introduce a GroupDisplayNameCache as we do for users. I can look into that, if we have figured out how to handle the conflicts.
Checklist
3. to review, feature component)stable32)