Skip to content

Conversation

@NoahOksuz
Copy link

@NoahOksuz NoahOksuz commented Dec 14, 2025

  • Resolves: #

Summary

Adds an --exclude-disabled option to the occ user:lastseen --all command to exclude disabled users from the results.

This addresses the feature request in #57044 allowing administrators to filter out disabled accounts when viewing last login times for all users.

Changes:

  • Added --exclude-disabled option to the LastSeen command
  • Modified execute method to skip disabled users when the option is enabled
  • Added unit tests to verify the new functionality

Fixes #57044
uh

Checklist

Signed-off-by: noah <noah.oeksuez@cyphersec.eu>
@NoahOksuz NoahOksuz requested a review from a team as a code owner December 14, 2025 18:26
@NoahOksuz NoahOksuz requested review from ArtificialOwl, CarlSchwan, come-nc and icewind1991 and removed request for a team December 14, 2025 18:26
@NoahOksuz NoahOksuz closed this Dec 14, 2025
@NoahOksuz NoahOksuz deleted the excludedisabled branch December 14, 2025 23:32
@NoahOksuz NoahOksuz restored the excludedisabled branch December 14, 2025 23:41
@NoahOksuz NoahOksuz reopened this Dec 14, 2025
@NoahOksuz
Copy link
Author

accidentaly deleted branch while doing some cleaning up blame it on me being tired

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpick on the test.

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@NoahOksuz
Copy link
Author

bumping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Additional parameter for occ user:lastseen --all for disabled accounts

2 participants