Skip to content

Conversation

@castillo92
Copy link
Contributor

@castillo92 castillo92 commented Jan 3, 2026

Summary

If you visit Settings -> Administration -> Sharing you can see 3 options and I think the text could be improved because, in short, the title and options are:

"Limit sharing based on groups:"

  • Allow all
  • Exclude some groups
  • Allow only some groups

And if you select any option, the textbox explain itself:

Line 133 :label="settings.excludeGroups === 'allow' ? t('settings', 'Groups allowed to share') : t('settings', 'Groups excluded from sharing')"

Therefore, I believe that text labels could be simplified.

TODO

  • Agree to my proposal and change text label.

Checklist

BEFORE:
Before

  • Documentation (manuals or wiki) has been updated or is not required
  • Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

Consistency

Signed-off-by: Castillo <37965565+castillo92@users.noreply.github.com>
@castillo92 castillo92 requested a review from a team as a code owner January 3, 2026 19:45
@castillo92 castillo92 requested review from artonge, sorbaugh and susnux and removed request for a team January 3, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant