refactor(Filesystem): delegate canonical normalization to PathHelper #57328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PathHelper::normalizePathto avoid duplicate implementationspreg*usageShouldn't introduce a BC. Retains existing checks:
PathHelper. I don't believe this is a BC, but noting.PathHelper'simplementation doesn't normalize out single dot paths/./; I retained that here in Filesystem's implementation, but we may want to add it to the PathHelper implementation for consistency (we could remove it from this implementation here when we do so).Couple notes:
normalizePath()implementations. Some of these unique ones may be valid/necessary, but an audit to make sure we're not either duplicating more logic or assuming checks that aren't actually there in some code paths would probably be a good idea.TODO
Checklist
3. to review, feature component)stable32)