refactor(LazyFolder): drop redundant normalizePath call in getFullPath

[joshtrichards]

Summary

isValidPath() already calls normalizePath() internally.

• Drops unnecessary extra call to PathHelper::normalizePath() in getFullPath()
• Switches class to constructor property promotion
• Updates class docblock

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[nickvergessen]

But it modifies the $path var which is used in returns of this function

[joshtrichards]

Doh! Obviously. I'm dumb.

[nickvergessen]

Doh! Obviously.

🙈

I'm dumb.

Wouldn't say that.
Also sorry for closing, the rest would still be valid. But removing this line adds a security related risk :P