Fix IP range null safety and add security IP tests#58369
Open
amussara wants to merge 1 commit intonextcloud:masterfrom
Open
Fix IP range null safety and add security IP tests#58369amussara wants to merge 1 commit intonextcloud:masterfrom
amussara wants to merge 1 commit intonextcloud:masterfrom
Conversation
…ests for IP security classes - Fix potential null pointer in Range::contains() where Factory::parseAddressString could return null, which would be passed directly to RangeInterface::contains() - Add comprehensive unit tests for Address class (valid/invalid parsing, isValid, matches, toString) - Add comprehensive unit tests for Range class (valid/invalid parsing, isValid, contains, toString) - Add comprehensive unit tests for Factory class (interface compliance, integration tests) Signed-off-by: amussara <amussara@users.noreply.github.com>
amussara
requested review from
Altahrim,
ArtificialOwl,
CarlSchwan and
leftybournes
and removed request for
a team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Null pointer fix in Range::contains() + 33 new PHP tests. 355 lines.