Skip to content

Conversation

@salonichf5
Copy link
Contributor

Proposed changes

Write a clear and concise description that helps reviewers understand the purpose and impact of your changes. Use the
following format:

Problem: We want to ensure everything works as expected for Session persistence feature

Solution: Add functional tests for Session persistence

Did some code refactoring for request and response, verified all tests pass

Note : need to check if ubi builds pass with experimental mode always on, or else need to fix this test

Testing: Ran tests locally

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #4232

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

NONE

@github-actions github-actions bot added the tests Pull requests that update tests label Dec 5, 2025
@salonichf5 salonichf5 force-pushed the tests/session-persistence branch from 96944ec to d83f893 Compare December 5, 2025 22:03
@tataruty
Copy link
Contributor

tataruty commented Dec 8, 2025

oh, thank you! this PR helps me a lot with ProxySettings functional tests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

Projects

Status: 🆕 New

Development

Successfully merging this pull request may close these issues.

3 participants