Skip to content

Conversation

@dixonjoel
Copy link
Collaborator

What does this Pull Request accomplish?

Rename custom metadata notebook and documentation to extension attributes.

Why should this Pull Request be merged?

Instead of custom metadata, the new term is extension attributes. This is also consistent with the LabVIEW examples.

What testing has been done?

Ran the notebook

@dixonjoel dixonjoel requested a review from csjall as a code owner November 20, 2025 20:26
Copilot AI review requested due to automatic review settings November 20, 2025 20:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames terminology from "custom metadata" to "extension attributes" to align with LabVIEW examples and establish consistent terminology across the codebase.

Key Changes

  • Updated docstring parameter descriptions in TestResult and Step classes to use "extension attributes" instead of "custom metadata"
  • Updated documentation index to reference the renamed notebook path

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/ni/datastore/data/_types/_test_result.py Updated the extension parameter docstring to say "extension attributes" instead of "custom metadata"
src/ni/datastore/data/_types/_step.py Updated the extension parameter docstring to say "extension attributes" instead of "custom metadata"
docs/examples/index.rst Updated notebook link from custom_metadata.ipynb to extension_attributes.ipynb and path from custom-metadata to extension-attributes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dixonjoel dixonjoel merged commit 4e382cc into main Nov 20, 2025
26 checks passed
@dixonjoel dixonjoel deleted the users/jdixon/extension-attributes-rename branch November 20, 2025 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants