Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Jun 16, 2025

This PR contains the following updates:

Package Update Change
third_party/ni-apis digest 0ded75d -> 93cbc66

Configuration

📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, only on Monday ( * 0-3 * * 1 ) (UTC), Automerge - Between 12:00 AM and 03:59 AM ( * 0-3 * * * ) (UTC).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot enabled auto-merge (squash) June 16, 2025 02:42
@renovate renovate bot requested review from bkeryan, csjall and dixonjoel as code owners June 16, 2025 02:42
@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2025

Test Results

    52 files  ±0      52 suites  ±0   1h 18m 49s ⏱️ + 1m 45s
   709 tests ±0     709 ✅ ±0      0 💤 ±0  0 ❌ ±0 
21 420 runs  ±0  20 344 ✅ ±0  1 076 💤 ±0  0 ❌ ±0 

Results for commit af4d628. ± Comparison against base commit 22cb41f.

♻️ This comment has been updated with latest results.

@dixonjoel
Copy link
Collaborator

@bkeryan I can't seem to fix the lint error in the sample_measurement. It says it need a newline above the TYPE_CHECKING but it already has one and I've tried adding newlines in and around there and 'poetry run ni-python-styleguid fix' doesn't do it.
~/work/measurement-plugin-python/measurement-plugin-python/examples/sample_measurement ~/work/measurement-plugin-python/measurement-plugin-python
./_array_utils.py:12:1: I300 TYPE_CHECKING block should have one newline above.
Error: Process completed with exit code 255.

Ideas?

@dixonjoel
Copy link
Collaborator

@bkeryan I can't seem to fix the lint error in the sample_measurement. It says it need a newline above the TYPE_CHECKING but it already has one and I've tried adding newlines in and around there and 'poetry run ni-python-styleguid fix' doesn't do it. ~/work/measurement-plugin-python/measurement-plugin-python/examples/sample_measurement ~/work/measurement-plugin-python/measurement-plugin-python ./_array_utils.py:12:1: I300 TYPE_CHECKING block should have one newline above. Error: Process completed with exit code 255.

Ideas?

@bkeryan I ended up tweaking the formatting of the lines above a little, deleting the existing end of line and recreating it. Some combination made the ni-python-styleguide happy on my machine so hopefully this PR (and then the next one) will pass.

@bkeryan
Copy link
Collaborator

bkeryan commented Jun 16, 2025

@bkeryan I can't seem to fix the lint error in the sample_measurement. It says it need a newline above the TYPE_CHECKING but it already has one and I've tried adding newlines in and around there and 'poetry run ni-python-styleguid fix' doesn't do it. ~/work/measurement-plugin-python/measurement-plugin-python/examples/sample_measurement ~/work/measurement-plugin-python/measurement-plugin-python ./_array_utils.py:12:1: I300 TYPE_CHECKING block should have one newline above. Error: Process completed with exit code 255.
Ideas?

@bkeryan I ended up tweaking the formatting of the lines above a little, deleting the existing end of line and recreating it. Some combination made the ni-python-styleguide happy on my machine so hopefully this PR (and then the next one) will pass.

@mshafer-NI is updating ni-python-styleguide to block flake8-import-order 0.19.0: ni/python-styleguide#225

@renovate
Copy link
Contributor Author

renovate bot commented Jun 16, 2025

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@renovate renovate bot merged commit 0bf16d3 into main Jun 17, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants