Skip to content

Conversation

@ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented May 19, 2023

  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

The nimibot GitHub actions workflows are updated to use v3 of the GitHub checkout action. v2 used Node.js 12 and this was causing annotations about it being deprecated to appear in the nimibot run summaries.

With v3, node16 runtime is used by default.

List issues fixed by this Pull Request below, if any.

What testing has been done?

PR Checks.

The annotations are gone. See

Ignore the failing readthedocs PR Checks. Those checks were added for #1963 and expect .readthedocs.yaml files that are added by that PR.

@ni-jfitzger ni-jfitzger marked this pull request as ready for review May 22, 2023 13:28
@ni-jfitzger ni-jfitzger requested a review from marcoskirsch as a code owner May 22, 2023 13:28
@marcoskirsch marcoskirsch merged commit 161f598 into ni:master May 23, 2023
@ni-jfitzger ni-jfitzger deleted the fix-node_js-annotations branch May 23, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github Actions Workflows should be updated to use Node.js 16 for checkout step

2 participants