-
Notifications
You must be signed in to change notification settings - Fork 99
Update nidcpower metadata #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2065 +/- ##
==========================================
- Coverage 92.07% 91.34% -0.73%
==========================================
Files 44 66 +22
Lines 13470 16274 +2804
==========================================
+ Hits 12402 14865 +2463
- Misses 1068 1409 +341
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 32 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
marcoskirsch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to resolve the code generation bug and possibly the enum mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CHANGELOG: link to issue and remove Source Breaker wording.
I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Updates metadata for nidcpower to latest 25.0 export.
Resulting changes:
INHIBITEDto enumOutputStatesOuputStates.VOLTAGEandOutputStates.CURRENTenum value names toOuputStates.CONSTANT_VOLTAGEandOutputStates.CONSTANT_CURRENTrespectivelymeasure_buffer_size,measure_complete_event_delay,source_delay, andmerged_channelsattributesconf.pyfiles in other modules so that the build passesList issues fixed by this Pull Request below, if any.
nidcpower.OutputStatesvalues are incorrect #2067What testing has been done?
PR checks