-
Notifications
You must be signed in to change notification settings - Fork 99
Support releasing individual packages in nimi-python #2090
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support releasing individual packages in nimi-python #2090
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2090 +/- ##
==========================================
- Coverage 91.34% 82.34% -9.01%
==========================================
Files 66 28 -38
Lines 16292 4004 -12288
==========================================
- Hits 14882 3297 -11585
+ Misses 1410 707 -703
Flags with carried forward coverage won't be shown. Click here to find out more. see 42 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
You're going to need to run flake8 on the Python scripts you touched and fix any failures. |
|
@rahulr-NI You should always set the PR title. Don't use GitHub's default PR title. |
This seems wrong. Wouldn't that command lead to a different error because you can't specify 2 of those arguments together? |
|
No need to rerun the system tests. The only thing that's changed since we last ran them is the check_latest_release workflow. |
CONTRIBUTING.md was modified to include the new parameters added while post-release, release using build_release.py file.
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
These changes will give flexibility of releasing only necessary package of nimi-python individually.
In "tools\build_release.py", are modified as below
--drivers parameter is included to accept the driver names specifically. If this parameter is not fed as input, all the drivers are considered. If incorrect driver names are provided as input, an appropriate error is given.
--update input is converted as below inputs.
--increment-major-version : Will give an ability to increment the version to (N+1).X.X.dev0 .
--increment-minor-version : Will give an ability to increment the version to X.(N+1).X.dev0 .
--increment-patch-version : Will give an ability to increment the version to X.X.(N+1).dev0 .
--update-for-release is added as a replacement of --release. It also removes the "devN" from the version number. It can be done specifically for each driver based on the --drivers parameter fed as input. If the current version doesn't has "devN" , it gives appropriate error.
updateReleaseInfo.py file is updated to support the changes done for tools\build_release.py
For ReadTheDocs changed with respect to individual versioning , the python regex is modified to accept "driver-X.X.X" as release tags so that the new versions gets generated whenever there is a release tagging done.
List issues fixed by this Pull Request below, if any.
No Issues fixed
What testing has been done?
Below are the version bumping test cases executed.
<style> </style>