Skip to content

Conversation

@rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented May 15, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

It provides support for Complex128, Complex64 and Int16 data type for all the modules.

No existing issues are fixed as part of this PR.

What testing has been done?

Tested by generating a waveform with a complex datatype and returned signal is correctly generated.

@codecov-commenter
Copy link

codecov-commenter commented May 15, 2025

Codecov Report

Attention: Patch coverage is 65.71429% with 24 lines in your changes missing coverage. Please review.

Project coverage is 91.25%. Comparing base (5ca52d6) to head (c1e19d2).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
build/helper/metadata_filters.py 18.18% 9 Missing ⚠️
generated/nifake/nifake/session.py 70.00% 9 Missing ⚠️
build/helper/codegen_helper.py 62.50% 3 Missing ⚠️
generated/nifake/nifake/_grpc_stub_interpreter.py 50.00% 3 Missing ⚠️

❌ Your patch status has failed because the patch coverage (65.71%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2098      +/-   ##
==========================================
- Coverage   91.35%   91.25%   -0.11%     
==========================================
  Files          66       67       +1     
  Lines       16318    16386      +68     
==========================================
+ Hits        14908    14953      +45     
- Misses       1410     1433      +23     
Flag Coverage Δ
codegenunittests 84.44% <53.84%> (-0.51%) ⬇️
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 86.72% <72.72%> (-0.53%) ⬇️
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
build/helper/__init__.py 100.00% <100.00%> (ø)
build/helper/helper.py 80.00% <ø> (ø)
build/helper/metadata_add_all.py 80.93% <100.00%> (+0.17%) ⬆️
build/helper/parameter_usage_options.py 100.00% <100.00%> (ø)
generated/nifake/nifake/_complextype.py 100.00% <100.00%> (ø)
build/helper/codegen_helper.py 83.71% <62.50%> (-0.68%) ⬇️
generated/nifake/nifake/_grpc_stub_interpreter.py 83.60% <50.00%> (-0.85%) ⬇️
build/helper/metadata_filters.py 72.81% <18.18%> (-6.54%) ⬇️
generated/nifake/nifake/session.py 80.21% <70.00%> (-0.71%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ca52d6...c1e19d2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI changed the title Support for complex type and enabling write_arb_waveform functions Support for complex type Jun 10, 2025
@ni-jfitzger ni-jfitzger changed the title Support for complex type Support for complex types Jul 7, 2025
@ni-jfitzger ni-jfitzger dismissed marcoskirsch’s stale review July 7, 2025 21:04

All threads resolved, so any requested changes should be addressed at this point.

@ni-jfitzger ni-jfitzger merged commit e697de8 into ni:master Jul 7, 2025
36 checks passed
rahulr-NI added a commit to rahulr-NI/nimi-python that referenced this pull request Jul 8, 2025
* Implementation of Complex Numbers

* Inclusion of test case for WriteWaveformComplexF64

* Implementation of f32 and i16 and respective test cases

* Updated changelog and included examples

* Updated the metadata

* Remove log file

* Updated functions.py file and few minor cahnges

* Update Changelog.md file

* Updated minor change.

* Updated few minor fix

* Updated the waveform type as ctype

* Updated the seesion lock parameter for new arb functions

* Updated Code Review comments

* Change log code review comments included

* Removed RFSG specific changes and include complextype only if needed

* Removed RFSG specific changes

* Updated matchers and complextype file to be generated bsaed on condition if complex is used

* Updating spacing issue

* Updating the complex variables and code review comments incorporated

* Test case name change

* Updating minor fixes

* Updating the test cases

* Update i16 functions

* Update duplicate entries

* remove zone.identifier file changes.

* Updaed comments for are_complex_parameters_used

* Updated the numpy api names and description.

* Updating default value of complext type as None rather than 'none'

* Moving the common lines in complex matchers into a function

* Updaing the library.py.mako file to import complex type

* Code Reivew Changes

* Updaed code review comments

* Updaing only necessary fields in COMPLEX_NUMBER_PARAMETERS
rahulr-NI added a commit to rahulr-NI/nimi-python that referenced this pull request Jul 8, 2025
* Implementation of Complex Numbers

* Inclusion of test case for WriteWaveformComplexF64

* Implementation of f32 and i16 and respective test cases

* Updated changelog and included examples

* Updated the metadata

* Remove log file

* Updated functions.py file and few minor cahnges

* Update Changelog.md file

* Updated minor change.

* Updated few minor fix

* Updated the waveform type as ctype

* Updated the seesion lock parameter for new arb functions

* Updated Code Review comments

* Change log code review comments included

* Removed RFSG specific changes and include complextype only if needed

* Removed RFSG specific changes

* Updated matchers and complextype file to be generated bsaed on condition if complex is used

* Updating spacing issue

* Updating the complex variables and code review comments incorporated

* Test case name change

* Updating minor fixes

* Updating the test cases

* Update i16 functions

* Update duplicate entries

* remove zone.identifier file changes.

* Updaed comments for are_complex_parameters_used

* Updated the numpy api names and description.

* Updating default value of complext type as None rather than 'none'

* Moving the common lines in complex matchers into a function

* Updaing the library.py.mako file to import complex type

* Code Reivew Changes

* Updaed code review comments

* Updaing only necessary fields in COMPLEX_NUMBER_PARAMETERS
@rahulr-NI rahulr-NI deleted the complexNumberSupport branch July 10, 2025 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants