-
Notifications
You must be signed in to change notification settings - Fork 99
Support for complex types #2098
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (65.71%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #2098 +/- ##
==========================================
- Coverage 91.35% 91.25% -0.11%
==========================================
Files 66 67 +1
Lines 16318 16386 +68
==========================================
+ Hits 14908 14953 +45
- Misses 1410 1433 +23
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
All threads resolved, so any requested changes should be addressed at this point.
* Implementation of Complex Numbers * Inclusion of test case for WriteWaveformComplexF64 * Implementation of f32 and i16 and respective test cases * Updated changelog and included examples * Updated the metadata * Remove log file * Updated functions.py file and few minor cahnges * Update Changelog.md file * Updated minor change. * Updated few minor fix * Updated the waveform type as ctype * Updated the seesion lock parameter for new arb functions * Updated Code Review comments * Change log code review comments included * Removed RFSG specific changes and include complextype only if needed * Removed RFSG specific changes * Updated matchers and complextype file to be generated bsaed on condition if complex is used * Updating spacing issue * Updating the complex variables and code review comments incorporated * Test case name change * Updating minor fixes * Updating the test cases * Update i16 functions * Update duplicate entries * remove zone.identifier file changes. * Updaed comments for are_complex_parameters_used * Updated the numpy api names and description. * Updating default value of complext type as None rather than 'none' * Moving the common lines in complex matchers into a function * Updaing the library.py.mako file to import complex type * Code Reivew Changes * Updaed code review comments * Updaing only necessary fields in COMPLEX_NUMBER_PARAMETERS
* Implementation of Complex Numbers * Inclusion of test case for WriteWaveformComplexF64 * Implementation of f32 and i16 and respective test cases * Updated changelog and included examples * Updated the metadata * Remove log file * Updated functions.py file and few minor cahnges * Update Changelog.md file * Updated minor change. * Updated few minor fix * Updated the waveform type as ctype * Updated the seesion lock parameter for new arb functions * Updated Code Review comments * Change log code review comments included * Removed RFSG specific changes and include complextype only if needed * Removed RFSG specific changes * Updated matchers and complextype file to be generated bsaed on condition if complex is used * Updating spacing issue * Updating the complex variables and code review comments incorporated * Test case name change * Updating minor fixes * Updating the test cases * Update i16 functions * Update duplicate entries * remove zone.identifier file changes. * Updaed comments for are_complex_parameters_used * Updated the numpy api names and description. * Updating default value of complext type as None rather than 'none' * Moving the common lines in complex matchers into a function * Updaing the library.py.mako file to import complex type * Code Reivew Changes * Updaed code review comments * Updaing only necessary fields in COMPLEX_NUMBER_PARAMETERS
What does this Pull Request accomplish?
It provides support for Complex128, Complex64 and Int16 data type for all the modules.
No existing issues are fixed as part of this PR.
What testing has been done?
Tested by generating a waveform with a complex datatype and returned signal is correctly generated.