-
Notifications
You must be signed in to change notification settings - Fork 99
NI-DCPower: Add examples for electronic loads #2103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NI-DCPower: Add examples for electronic loads #2103
Conversation
- Add `nidcpower_constant_resistance_and_constant_power.py` and `nidcpower_sink_dc_current_into_electronic_load.py` - Regenerate `docs/nidcpower/examples.rst` - Update CHANGELOG.md to call out the new examples
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2103 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 66 66
Lines 16318 16318
=======================================
+ Hits 14908 14909 +1
+ Misses 1410 1409 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
We have a grand total of four |
src/nidcpower/examples/nidcpower_constant_resistance_and_constant_power.py
Outdated
Show resolved
Hide resolved
As discussed previously in our meeting with the stakeholders, Python examples provide value to our customers due to its increased adoption, and hence we should be opportunistic to incrementally add example support for Python for newer products / features, even though it was de-prioritized in the past. |
@marcoskirsch I'm surprised there aren't really any examples of basic use cases, similar to The existing examples seem to demonstrate (somewhat) advanced use cases:
|
src/nidcpower/examples/nidcpower_constant_resistance_and_constant_power.py
Outdated
Show resolved
Hide resolved
src/nidcpower/examples/nidcpower_sink_dc_current_into_electronic_load.py
Outdated
Show resolved
Hide resolved
src/nidcpower/examples/nidcpower_sink_dc_current_into_electronic_load.py
Outdated
Show resolved
Hide resolved
src/nidcpower/examples/nidcpower_sink_dc_current_into_electronic_load.py
Outdated
Show resolved
Hide resolved
ni-jfitzger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are several places where you haven't followed Marcos's recommendation to refer to exact symbol names and I believe it hurts the clarity.
What does this Pull Request accomplish?
nidcpower_constant_resistance_and_constant_power.pyandnidcpower_sink_dc_current_into_electronic_load.pydocs/nidcpower/examples.rst--option-stringparameter to "Option String" based on IVI conventionWhat testing has been done?
toxandtox -c .\generated\nidcpower\tox-system_tests.inisucceeded