-
Notifications
You must be signed in to change notification settings - Fork 99
corrected datatype to float64 list and turned on some apis #2106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
corrected datatype to float64 list and turned on some apis #2106
Conversation
8b4c517 to
473d86f
Compare
…thub.com/Vaishnavigupta1312/nimi-python into users/vagupta/modifications-in-rfsg-apis
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2106 +/- ##
=======================================
Coverage 91.35% 91.36%
=======================================
Files 66 66
Lines 16318 16318
=======================================
+ Hits 14908 14909 +1
+ Misses 1410 1409 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
I'm not sure what you mean, exactly, but overall this PR looks okay. |
We don't have a p2p Python API. You should exclude all related functions, attributes and enums. |
|
The RF team has agreed to remove the P2P stuff in a follow-up PR. |
* corrected datatype to float64 list and turned on some apis * updated metadata after resolving conflicts * corrected name of APIs and removed mismatched enum value
[ x ] This contribution adheres to CONTRIBUTING.md.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
configure_p2p_endpoint_fullness_start_trigger,create_deembedding_sparameter_table_s2p_fileWhat testing has been done?