Skip to content

Conversation

@Vaishnavigupta1312
Copy link
Contributor

@Vaishnavigupta1312 Vaishnavigupta1312 commented Jun 12, 2025

[ x ] This contribution adheres to CONTRIBUTING.md.

[ ] I've updated CHANGELOG.md if applicable.

[ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Modified helper script to not split the API name if a number is followed by an uppercase for RFSG APIs like - configure_p2p_endpoint_fullness_start_trigger , create_deembedding_sparameter_table_s2p_file
  • Corrected the parameter locations to be an array of type float64
  • Corrected enum values for RF filter
  • Enabled the APIs configuring locations
  • Enabled errorMessage, errorQuery and revisionQuery APIs

What testing has been done?

  • tox build
  • no modifications in the generated MI driver APIs after tooling changes

@Vaishnavigupta1312 Vaishnavigupta1312 marked this pull request as ready for review June 16, 2025 13:36
@Vaishnavigupta1312 Vaishnavigupta1312 force-pushed the users/vagupta/modifications-in-rfsg-apis branch from 8b4c517 to 473d86f Compare June 17, 2025 09:25
@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (473d86f) to head (f799e35).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2106   +/-   ##
=======================================
  Coverage   91.35%   91.36%           
=======================================
  Files          66       66           
  Lines       16318    16318           
=======================================
+ Hits        14908    14909    +1     
+ Misses       1410     1409    -1     
Flag Coverage Δ
codegenunittests 84.95% <100.00%> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.24% <ø> (ø)
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
build/helper/helper.py 80.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 473d86f...f799e35. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger
Copy link
Collaborator

Corrected the parameter locations to be an array of type float64

I'm not sure what you mean, exactly, but overall this PR looks okay.

@ni-jfitzger
Copy link
Collaborator

configure_p2p_endpoint_fullness_start_trigger

We don't have a p2p Python API. You should exclude all related functions, attributes and enums.

@ni-jfitzger
Copy link
Collaborator

The RF team has agreed to remove the P2P stuff in a follow-up PR.
create_deembedding_sparameter_table_s2p_file still seems to need the helper change, so I'll go ahead with the merge.

@ni-jfitzger ni-jfitzger merged commit 051d74d into ni:master Jul 1, 2025
36 checks passed
rahulr-NI pushed a commit to rahulr-NI/nimi-python that referenced this pull request Jul 8, 2025
* corrected datatype to float64 list and turned on some apis

* updated metadata after resolving conflicts

* corrected name of APIs and removed mismatched enum value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants