Skip to content

Conversation

@Vaishnavigupta1312
Copy link
Contributor

@Vaishnavigupta1312 Vaishnavigupta1312 commented Jun 22, 2025

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

  • Corrected the indentation
  • Updated NI-RFSG documentation
    • Added double quotes to possible value names
    • Replaced deleted string enum occurrences with actual string values

What testing has been done?

tox build
manual validation of rendered HTML pages

@Vaishnavigupta1312 Vaishnavigupta1312 force-pushed the users/vagupta/rfsg-documentation-update branch from 5c3c3d9 to 473d86f Compare June 22, 2025 15:24
@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.38%. Comparing base (8a06f63) to head (c4a445c).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2107      +/-   ##
==========================================
+ Coverage   89.72%   91.38%   +1.66%     
==========================================
  Files          61       67       +6     
  Lines       14339    16664    +2325     
==========================================
+ Hits        12865    15229    +2364     
+ Misses       1474     1435      -39     
Flag Coverage Δ
codegenunittests 86.37% <ø> (+1.42%) ⬆️
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (?)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 87.05% <ø> (-0.20%) ⬇️
nifgensystemtests 94.86% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a06f63...c4a445c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Vaishnavigupta1312 Vaishnavigupta1312 marked this pull request as ready for review June 30, 2025 06:20
@ni-jfitzger ni-jfitzger merged commit a488e07 into ni:master Jul 7, 2025
36 checks passed
rahulr-NI pushed a commit to rahulr-NI/nimi-python that referenced this pull request Jul 8, 2025
* Updated documentation and metadata changes

* Updated the helper script to not split names when number is followed by uppercase

* Updated CHANGELOG.md

* Latest metadata

* minor modification in metadata

* removed changelog change since its internal and adding the built files

---------

Co-authored-by: vnktshr21 <venkatesh.rathnavelu@emerson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants