Update nidcpower proto file to match 25.3 final #2108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@bkeryan I'm thinking there's no point in doing this because the proto file in grpc-device hasn't been updated in several years. What do you think? |
Collaborator
|
This seems fine to me. I admit I do not fully understand the impact of your comment to @bkeryan. |
tobiasgordon
approved these changes
Jul 1, 2025
Collaborator
tobiasgordon
left a comment
tobiasgordon
left a comment
There was a problem hiding this comment.
This update looks fine to me. Even if grpc-device has not been updated recently, it's less technical debt to continue updating it here.
rahulr-NI
pushed a commit
to rahulr-NI/nimi-python
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ ] I've updated CHANGELOG.md if applicable.[ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Update the nidcpower proto file from the 25.3 internal export and rerun codegen.
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Checks