-
Notifications
You must be signed in to change notification settings - Fork 99
Complex numbers updates for nifake and nirfsg #2131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complex numbers updates for nifake and nirfsg #2131
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2131 +/- ##
=======================================
Coverage 89.07% 89.08%
=======================================
Files 71 71
Lines 18960 18960
=======================================
+ Hits 16889 16890 +1
+ Misses 2071 2070 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
@rahulr-NI travis-ci says that "generated/nirfsg/nirfsg/session.py" isn't up-to-date. |
|
I have updated the description slightly to be useful to people who don't work at NI, since this is an Open Source repository. |
I have update it Jay. It was because array_representation parameter was written as array_representations in metadata. This change is addressed in multi-dimensional array pr. Resolving it here as well. Thanks. |
|
I probably already suggested some test be added to |
- [ ] I've updated CHANGELOG.md if applicable.- [ ] I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
This PR is update the nimi-python repository metadata files with those from NI's private repository with updates to complex number related APIs.
Below are the changes done.
What testing has been done?
Ensured that tox build is successful and generated changes are intended.