Skip to content

Conversation

@rahulr-NI
Copy link
Contributor

@rahulr-NI rahulr-NI commented Sep 11, 2025

- [ ] I've updated CHANGELOG.md if applicable.

- [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

This PR is update the nimi-python repository metadata files with those from NI's private repository with updates to complex number related APIs.
Below are the changes done.

  • Updated the complex_type parameter as complex_array_presentation as the code review comments received iternally at NI. And its value changes.
  • Code gen changes with respect to above variable names changes.
  • Removed complex_type default value setting in test_codegen_helper.py file as this remains unused.
  • Incorporating other AzDo PR comments like changing API description, parameter desciption update as received in PR

What testing has been done?

Ensured that tox build is successful and generated changes are intended.

@codecov-commenter
Copy link

codecov-commenter commented Sep 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.08%. Comparing base (4b9434f) to head (b978a13).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2131   +/-   ##
=======================================
  Coverage   89.07%   89.08%           
=======================================
  Files          71       71           
  Lines       18960    18960           
=======================================
+ Hits        16889    16890    +1     
+ Misses       2071     2070    -1     
Flag Coverage Δ
codegenunittests 84.44% <100.00%> (ø)
nidcpowersystemtests 94.65% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.26% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.72% <ø> (ø)
nifakeunittests 85.52% <ø> (ø)
nifgensystemtests 94.61% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 75.78% <ø> (ø)
niscopesystemtests 92.94% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 82.03% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
build/helper/codegen_helper.py 83.71% <100.00%> (ø)
build/helper/metadata_add_all.py 81.10% <100.00%> (ø)
build/helper/metadata_filters.py 72.81% <100.00%> (ø)
generated/nifake/nifake/session.py 77.50% <ø> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b9434f...b978a13. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rahulr-NI rahulr-NI changed the title Complex numbers updates for niFake and niRfsg Complex numbers updates for nifake and nirfsg Sep 11, 2025
@rahulr-NI rahulr-NI marked this pull request as ready for review September 11, 2025 13:18
@ni-jfitzger
Copy link
Collaborator

@rahulr-NI travis-ci says that "generated/nirfsg/nirfsg/session.py" isn't up-to-date.

@marcoskirsch
Copy link
Member

I have updated the description slightly to be useful to people who don't work at NI, since this is an Open Source repository.

@rahulr-NI
Copy link
Contributor Author

I have updated the description slightly to be useful to people who don't work at NI, since this is an Open Source repository.

@rahulr-NI travis-ci says that "generated/nirfsg/nirfsg/session.py" isn't up-to-date.

I have update it Jay. It was because array_representation parameter was written as array_representations in metadata. This change is addressed in multi-dimensional array pr. Resolving it here as well. Thanks.

@rahulr-NI rahulr-NI closed this Sep 15, 2025
@rahulr-NI rahulr-NI reopened this Sep 15, 2025
@ni-jfitzger
Copy link
Collaborator

I probably already suggested some test be added to build/unit_tests/test_codegen_helper.py. Still applies but it doesn't need to be done as part of this PR.

@marcoskirsch marcoskirsch merged commit e6533a3 into ni:master Sep 16, 2025
39 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants