Testing Snyk PR integration #170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added intentionally insecure code examples for SAST testing.
cameronwaterman
requested review from
rbell517 and
spanglerco
as code owners
⛔ Snyk checks have failed. 2 issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
| """ | ||
| # Hardcoded secrets / credentials | ||
| password = "P@ssw0rd!" # hardcoded password | ||
| api_key = "AKIA1234567890FAKE" # fake AWS-style access key |
There was a problem hiding this comment.
Hardcoded Non-Cryptographic Secret
Avoid hardcoding values that are meant to be secret. Found a hardcoded string used in here.
Line 124 | CWE-547 | Priority score 820
Data flow: 2 steps
Step 1 - 2
|
|
||
| # Insecure HTTP request (certificate verification disabled) | ||
| import requests | ||
| r = requests.get(url, verify=False) |
There was a problem hiding this comment.
Improper Certificate Validation - SSL Verification Bypass
Certificate verification is disabled by setting verify to False in requests.get. This may lead to Man-in-the-middle attacks.
Line 146 | CWE-295 | Priority score 820
Data flow: 3 steps
Step 1 - 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TEST PR TO BE CLOSED