Skip to content

Conversation

@spanglerco
Copy link
Collaborator

What does this Pull Request accomplish?

Updates flake8 and related dependencies to latest. Stop pinning to specific versions per NI convention.

Why should this Pull Request be merged?

Resolves a bug affecting #174, where flake8 is flagging colons and commas within format strings.

What testing has been done?

Ran flake8 locally. Relying on PR workflow.

Copy link
Collaborator

@rbell517 rbell517 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already covered by the flake8 update in #168 which updates to flake8 v7 but keeps the major version pinned. That is my preference so we don't have wildly different flake8 behavior based on which version the developer might happen to have in their venv. That PR is basically ready to go in I just haven't found the time to address the couple comments and resolve the merge conflicts. Would you be willing to push that one over the finish line instead of continuing with this PR? I know your other PR is blocked on this, so I can be flexible.

@spanglerco
Copy link
Collaborator Author

This is already covered by the flake8 update in #168 which updates to flake8 v7 but keeps the major version pinned. That is my preference so we don't have wildly different flake8 behavior based on which version the developer might happen to have in their venv. That PR is basically ready to go in I just haven't found the time to address the couple comments and resolve the merge conflicts. Would you be willing to push that one over the finish line instead of continuing with this PR? I know your other PR is blocked on this, so I can be flexible.

Yeah, I can take a look at the other PR. I can incorporate the @classproperty typing fix from this PR as well to remove some casts.

@spanglerco
Copy link
Collaborator Author

Superseded by #168.

@spanglerco spanglerco closed this Dec 10, 2025
@spanglerco spanglerco deleted the users/pspangle/flake8 branch December 10, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants