Changed argument name for all __eq__ methods except in scalar.py #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h is covered separately) from value, which may have been confusing, to other, which is clear. Improved formatting of a doc string associated with __eq__ methods. Signed-off-by: Kosta Ilic <kosta.ilic@emerson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
eq methods in all classes had an argument named "value". This was confusing in context of scalar, where one of the data members was also named "value", so we decided to change the argument name to "other". This change is the equivalent change in other classes.
Why should this Pull Request be merged?
To reduce potential for future confusion and to restore consistency in argument names between classes.
What testing has been done?
I am leaning on automated tests that are part of CI.